Pin synapse-api to main (2.4.1) and support peripheral_id in impedance queries#183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
synapse-apisubmodule to the current head of main (cacec78), which addsperipheral_id(uint32, field 2) toImpedanceQueryand bumps the API version to 2.4.1synapse/_api_version.pyto 2.4.1 (generated from the submodule's VERSION file)peripheral_identry to the exampletest_query.jsonSince the Python bindings are generated from the submodule at build time and the CLI parses query JSON directly into the proto, a
"peripheral_id"entry in a query file flows throughsynapsectl queryautomatically once the submodule is repinned.Test plan
pytestpasses (24 tests)peripheral_idfrom query JSON